Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial support for ipv6 #73

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Trivial support for ipv6 #73

merged 4 commits into from
Jan 26, 2024

Conversation

raul-arabaolaza
Copy link
Contributor

Needed by some proprietary code I believe this could also be interesting to the community.
While arguably we want to stop using this library and move to test containers this change is so small that I can not resist to contribute it back. There may be a potential effort on migrating the ath and plugin tests to test containers that I totally endorse, but nothing prevents us to do that and this in parallel given the test containers migration is gonna require more effort.

Testing done

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@raul-arabaolaza
Copy link
Contributor Author

Successfully tested on proprietary runs of both the ATH and the PCT

@raul-arabaolaza raul-arabaolaza marked this pull request as ready for review January 22, 2024 10:48
@jglick jglick added the bug label Jan 26, 2024
@jglick jglick merged commit 7474b01 into jenkinsci:master Jan 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants