Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fsGroupChangePolicy: "OnRootMismatch" is not set #970

Open
dee-kryvenko opened this issue Dec 14, 2023 · 3 comments
Open

fsGroupChangePolicy: "OnRootMismatch" is not set #970

dee-kryvenko opened this issue Dec 14, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@dee-kryvenko
Copy link

Describe the bug

This helm chart is setting fsGroup. When fsGroup is used, most of the times unless there are reasons not to - fsGroupChangePolicy: "OnRootMismatch" must be set. This is especially relevant for Jenkins with its CPS/survivability implementation. My Jenkins instance has 31 million xml files. To attach a volume - takes 15+ minutes, and that's super performant nvme ssd based volume. Probably could take an hour on a regular EBS or something like that.

Version of Helm and Kubernetes

- Helm: 
- Kubernetes:

Chart version

irrelevant

What happened?

1.
2.
3.
...

What you expected to happen?

No response

How to reproduce it

No response

Anything else we need to know?

No response

@dee-kryvenko dee-kryvenko added the bug Something isn't working label Dec 14, 2023
@timja
Copy link
Member

timja commented Dec 14, 2023

Did you want to send a pull request?

@mohanisch-sixt
Copy link
Contributor

As far as I can see podSecurityContextOverride should make it:

  podSecurityContextOverride:
    runAsUser: 1000
    fsGroup: 1000
    fsGroupChangePolicy: "OnRootMismatch"
    runAsNonRoot: true
    supplementalGroups: [1000]

@dee-kryvenko
Copy link
Author

Yes I can send a PR when I get a minute. @mohanisch-sixt I am currently using podSecurityContextOverride as a workaround, however

  1. Chart is setting fsGroup by default with no user input, which without fsGroupChangePolicy to go with it results in a non-optimal settings. For unexperienced user, this may not be evident what the problem is and why it takes 15+ minutes to start Jenkins.
  2. podSecurityContextOverride currently requires me to set a bunch of other options that I would like to leave default. If this chart tomorrow decides to change runAsUser, I should not be required to inspect every commit line by line on the off chance my override needs to change as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants