Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove git workarounds #606

Merged
merged 3 commits into from
Oct 24, 2023
Merged

remove git workarounds #606

merged 3 commits into from
Oct 24, 2023

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Oct 23, 2023 •
edited

the BOM has moved on meaning backports are not needed, additionally many plugins awaiting a release have been released so we can remove the workarounds

fixes: #561 #560 #548 #547 #546 #562 #549

obsoletes #551

Testing done

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@jtnord
remove obsolete workarounds
3c68d51 
the BOM has moved on meaning backports are not needed, additionally many plugins awaiting a release have been released so we can remove the workarounds
@jtnord jtnord requested a review from a team as a code owner October 23, 2023 17:00
@jtnord jtnord changed the title remove obsolete workarounds remove git workarounds Oct 24, 2023
@jtnord jtnord enabled auto-merge October 24, 2023 07:57
@jtnord jtnord added the chore label Oct 24, 2023
@jtnord jtnord merged commit 43076c5 into master Oct 24, 2023
14 checks passed
@jtnord jtnord deleted the remove-workarounds branch October 24, 2023 08:08
basil
basil reviewed Oct 26, 2023
View reviewed changes
src/main/java/org/jenkins/tools/test/PluginCompatTester.java
Comment on lines -342 to -346
// TODO pending release of
// https://github.com/jenkinsci/kubernetes-credentials-plugin/pull/37
gitUrl = gitUrl.replace(
"git://github.com/jenkinsci/kubernetes-credentials-plugin",
"https://github.com/jenkinsci/kubernetes-credentials-plugin");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtnord The removal of this workaround is causing problems for jenkinsci/bom, which still (on its 2.387.x line) uses kubernetes-credentials-0.10.0, which does not have the SCM change in its POM.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that - I thought I had checked all versions.
#608

@basil basil mentioned this pull request Oct 26, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basil basil basil left review comments

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove bootstrap5-api, data-tables-api, and echarts-api workarounds
2 participants
@jtnord @basil