job triggered anyway when don't trigger condition is met

[badcorporatelogo]

When configuring a phase job with "Parameters from properties file", there is a checkbox to say, "Don't trigger if any files are missing".

The condition gets evaluated correctly, but the job is always triggered. In cases where the properties file doesn't exist, the job is triggered with no arguments.

The console log looks like this:

    >> Job status: [downstream-job-part1] the 'build only if scm changes' feature is disabled.
Starting build job downstream-job-part1.
[parameterized-trigger] Properties file part1.props did not exist.
Not triggering due to missing file - did you archive it as a build artifact ?
[multiJob] DontTriggerException: hudson.plugins.parameterizedtrigger.AbstractBuildParameters$DontTriggerException

Despite saying it won't trigger the job, it does anyway.

The reason why appears to be here:
https://github.com/jenkinsci/tikal-multijob-plugin/blob/master/src/main/java/com/tikal/jenkins/plugins/multijob/PhaseJobsConfig.java#L496

At this line, we need to add params = null; to fix the bug.

The implementation assigns a default value to params (as described in the comments on lines 447-449). Then at the end of the function, on line 501, it conditionally adds the params to the actions list. The catch block for DontTriggerException needs to discard the default params value and set it back to null, in order to "override" it as described in the function comments.