Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return incorrect month format in "ru" & "uk" translations after call ->format('M') #319

Open
Kanzafarov opened this issue Mar 28, 2019 · 6 comments

Comments

@Kanzafarov
Copy link

Hi, sorry for my bad English.

Into lang files "ru" and "uk" we have duplicate keys in 30 and 43 lines:
30: 'may' => 'май'
43: 'may' => '{0}май|{1}мая'.

And if call some date with "->format('M')" we get '{0}май|{1}мая' instead expected "май".

@kylekatarnls
Copy link
Contributor

Duplicate of #253 and #272, initially it could have been fixed by #298 but now it would be probably more relevant to simply use Carbon translations instead: #317

@Magnecor
Copy link

Magnecor commented May 4, 2019

How to fix it now? Everything worked fine!

@MaxNozhkin
Copy link

+1

@mail47002
Copy link

Hello
I have this problem
https://imgur.com/3rz8etv
08 {0}травень|{1}травня - 30 чер

@kylekatarnls
Copy link
Contributor

For the record, Carbon handle it just fine:

Carbon::setLocale('uk');

echo Carbon::parse('2019-05-08')->translatedFormat('d M');
08 тра

So you can rely on the base features with jenssegers too:

Date::setLocale('uk');

echo Date::parse('2019-05-08')->translatedFormat('d M');

@kylekatarnls
Copy link
Contributor

Fixed in 4.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants