Fix and update the docker + bats based tests #413
+112
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmeszaros
force-pushed
the
docker-test-update
branch
from
f26cd9f
to
ad07fa2
Compare
andrewflbarnes
requested changes
Mar 16, 2024
test/Dockerfile
Outdated
| RUN yum install -y java-11-openjdk | ||
| RUN yum install -y java-1.7.0-openjdk | ||
| RUN yum install -y java-1.8.0-openjdk | ||
| RUN curl -L https://github.com/graalvm/graalvm-ce-builds/releases/download/vm-22.3.3/graalvm-ce-java11-linux-$(arch)-22.3.3.tar.gz | tar xzf - -C /usr/lib/jvm/ |
There was a problem hiding this comment.
If $(arch) is x86_64 should get amd64
test/adding_jdks.bats
Outdated
Comment on lines
21
to
22
| @test "add openjdk 1.8.0.372" { | ||
| jenv add /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.372.b07-1.el7_9.$_ARCH/jre/ |
There was a problem hiding this comment.
Should probably make this and other add commands not depend on build version as tests are brittle - some of these are out of date again e.g.
Suggested change
| @test "add openjdk 1.8.0.372" { | |
| jenv add /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.372.b07-1.el7_9.$_ARCH/jre/ | |
| @test "add openjdk 1.8.0" { | |
| jenv add /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.*.el7_9.$_ARCH/jre/ |
test/adding_jdks.bats
Outdated
Comment on lines
26
to
27
| assert_line --regexp '^ *1.8.0.372$' | ||
| assert_line --regexp '^ *openjdk64-1.8.0.372$' |
There was a problem hiding this comment.
As other comment should make these and other assertions not depend on build version as tests are brittle and some of these are out of date again
Suggested change
| assert_line --regexp '^ *1.8.0.372$' | |
| assert_line --regexp '^ *openjdk64-1.8.0.372$' | |
| assert_line --regexp '^ *1.8.0.[0-9]+$' | |
| assert_line --regexp '^ *openjdk64-1.8.0.[0-9]+$' |
This should ensure that tests will not break over time.
Also removed the unused _ARCH var from the test suite_setup.
Removed unnecessary subshell creations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make tests green the following needed to be done:
adding_jdks.batstestssetting_versions.batstestsAdditionally I added some improvements:
setupinto:setup_suite,setupandteardownsetting_versions.batsFixes #411