-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variadic macros used in manner not compliant with ISO C++11 #107
Comments
Hi, However, if this is the only thing, or one of few things, in the library that doesn’t get along with -Wpedantic and it would make a big difference for you I’d be happy to merge a PR. |
I'd like to see this addressed in the cpptrace header please. Use of the pedantic flag opens one up to issues like this where it is desirable to see pedantic warnings in a project but we get distractions from pedantic warnings in third party headers. It's worse when one is trying to clean up a codebase and have the pedantic warnings treated as errors because it means the project fails to build even though the code of the project itself might be ok. |
If this is affecting multiple users then it's reasonable to try to resolve and support. I can try to resolve this since I haven't heard back from OP. @marlowa Are you seeing pedantic warnings in cpptrace public-facing headers? (i.e. cpptrace.hpp and ctrace.h) If so, what compiler are you using? I wasn't able to reproduce any with a brief test https://godbolt.org/z/Tnj1G3Wbz. |
Compiling with
-Wpedantic
reveals a significant number of warnings surrounding the use of the assertion macros inutils/error.hpp
. It seems that invoking such a macro without at least one argument for the...
is a violation of ISO C++11. It makes sense to me.I can submit a PR to separate these macros out into versions with and without messages attached to them.
The text was updated successfully, but these errors were encountered: