fix: Node package dependencies ending up as related dependency of the wrong version of the package #5479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #5477
Description of Change
Fix-up location determination of the base folder for package.json so that when multiple versions of a package are in the node_modules tree the versions that differ from the version in the root get associated with the appropriate version (which is in the private node_modules folder of their parent)
Have test cases been added to cover the new functionality?
no, locally tested with npm v6, v8 and v9 (package-lock versions 1, 2 and 3) using the reference package.json of the issue in a gradle project.