Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add LibmanAnalyzer #5652

Merged
merged 7 commits into from
Apr 19, 2023

Conversation

ArjenKorevaar
Copy link
Contributor

@ArjenKorevaar ArjenKorevaar commented Apr 5, 2023

Fixes Issue #1567

Description of Change

Adds an analyzer for Libman package references from libman.json files.

Have test cases been added to cover the new functionality?

Yes

@boring-cyborg boring-cyborg bot added ant changes to ant core changes to core documentation site documentation maven changes to the maven plugin tests test cases utils changes to utils labels Apr 5, 2023
@ArjenKorevaar ArjenKorevaar changed the title Add LibmanAnalyzer feat: add LibmanAnalyzer Apr 5, 2023
@jeremylong
Copy link
Owner

Thanks for the PR! I've been on vacation - I will review this early next week.

@ArjenKorevaar
Copy link
Contributor Author

Rebased onto jeremylong:main

@jeremylong jeremylong added this to the 8.2.2 milestone Apr 19, 2023
Copy link
Owner

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremylong jeremylong merged commit 55085e8 into jeremylong:main Apr 19, 2023
7 checks passed
@jeremylong
Copy link
Owner

Thanks for the PR!

@ArjenKorevaar ArjenKorevaar deleted the feature/LibmanAnalyzer branch April 19, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ant changes to ant core changes to core documentation site documentation maven changes to the maven plugin tests test cases utils changes to utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants