-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add LibmanAnalyzer #5652
Merged
jeremylong
merged 7 commits into
jeremylong:main
from
ArjenKorevaar:feature/LibmanAnalyzer
Apr 19, 2023
Merged
feat: add LibmanAnalyzer #5652
jeremylong
merged 7 commits into
jeremylong:main
from
ArjenKorevaar:feature/LibmanAnalyzer
Apr 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
ant
changes to ant
core
changes to core
documentation
site documentation
maven
changes to the maven plugin
tests
test cases
utils
changes to utils
labels
Apr 5, 2023
Thanks for the PR! I've been on vacation - I will review this early next week. |
ArjenKorevaar
force-pushed
the
feature/LibmanAnalyzer
branch
from
April 15, 2023 09:14
132ade3
to
2c951b5
Compare
Rebased onto jeremylong:main |
jeremylong
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #1567
Description of Change
Adds an analyzer for Libman package references from libman.json files.
Have test cases been added to cover the new functionality?
Yes