go install leaves the binary "unversioned"

[jbrains]

When I use go install to install lazygit, the resulting binary is "unversioned" according to lazygit --version. I presume that we'd like to have some build metadata available, especially to help with debugging/diagnosing defects.

1. Clone the lazygit source.
2. go install
3. $HOME/.go/bin/lazygit --version

I get commit=, build date=, build source=unknown, version=unversioned, os=linux, arch=amd64, but I expect at least the commit hash in this metadata.

Desktop (please complete the following information):

• Pop!_OS 21.04
• The last commit id if you built project from sources: 6c415d1

[mjarkk]

This might sound wired but this somewhat intended behavior.
These values are explicitly set in the CD, see /.goreleaser.yml#18 for how we do that.

But your point is still valid maybe we should have some go code generator that sets these values automatically.

[jbrains]

Not weird, merely unexpected.

Should I use goreleaser, then, to build locally from source? (I just happened to learn yesterday what the sentence even means.)

[jesseduffield]

If there is a way to bake in the current tag or commit hash via go install I would definitely do that, but I don't actually know how haha

[jesseduffield]

This guide shows a way to do it, however it would require us providing a shell script that handles the different variables https://blog.alexellis.io/inject-build-time-vars-golang/

[jesseduffield]

I think Go might actually support this natively now: golang/go#37475

[jbrains]

Excellent! Since I build from source, I find it helpful be able to confirm that I indeed built the expected version of lazygit and installed it to the right place without checking file timestamps.

[jesseduffield]

This is fixed in #2076

While I have the chance @jbrains I wanna say I've come across your blog posts on testing and they are phenomenal. Thanks for writing them!

[jbrains]

I have the fix! Thank you.