Fetch all items in the bucket #344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilburn
force-pushed
the
master
branch
2 times, most recently
from
e729567
to
3a78d0b
Compare
AWS API limits list responses to 1000 items. If the bucket is larger, subsequent requests are needed to actually fetch all of the items in the bucket. This commit implements iteration logic to keep fetching while there are more (not-returned-yet) results. Fixes jessestuart#343
|
@jessestuart could you merge this please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS API limits list responses to 1000 items. If the bucket is larger,
subsequent requests are needed to actually fetch all of the items in the
bucket.
This commit implements iteration logic to keep fetching while there are
more (not-returned-yet) results.
Fixes #343