/
prefer-todo.ts
100 lines (90 loc) · 2.41 KB
/
prefer-todo.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
import {
AST_NODE_TYPES,
TSESLint,
TSESTree,
} from '@typescript-eslint/experimental-utils';
import {
JestFunctionCallExpression,
TestCaseName,
createRule,
getNodeName,
hasOnlyOneArgument,
isFunction,
isStringNode,
isTestCase,
} from './utils';
function isEmptyFunction(node: TSESTree.Expression) {
if (!isFunction(node)) {
return false;
}
/* istanbul ignore if https://github.com/typescript-eslint/typescript-eslint/issues/734 */
if (!node.body) {
throw new Error(
`Unexpected null while performing prefer-todo - please file a github issue at https://github.com/jest-community/eslint-plugin-jest`,
);
}
return (
node.body.type === AST_NODE_TYPES.BlockStatement &&
node.body.body &&
!node.body.body.length
);
}
function createTodoFixer(
node: JestFunctionCallExpression<TestCaseName>,
fixer: TSESLint.RuleFixer,
) {
const testName = getNodeName(node.callee).split('.').shift();
return fixer.replaceText(node.callee, `${testName}.todo`);
}
const isTargetedTestCase = (
node: TSESTree.CallExpression,
): node is JestFunctionCallExpression<TestCaseName> =>
isTestCase(node) &&
[TestCaseName.it, TestCaseName.test, 'it.skip', 'test.skip'].includes(
getNodeName(node.callee),
);
export default createRule({
name: __filename,
meta: {
docs: {
category: 'Best Practices',
description: 'Suggest using `test.todo`',
recommended: false,
},
messages: {
emptyTest: 'Prefer todo test case over empty test case',
unimplementedTest: 'Prefer todo test case over unimplemented test case',
},
fixable: 'code',
schema: [],
type: 'layout',
},
defaultOptions: [],
create(context) {
return {
CallExpression(node) {
const [title, callback] = node.arguments;
if (!title || !isTargetedTestCase(node) || !isStringNode(title)) {
return;
}
if (callback && isEmptyFunction(callback)) {
context.report({
messageId: 'emptyTest',
node,
fix: fixer => [
fixer.removeRange([title.range[1], callback.range[1]]),
createTodoFixer(node, fixer),
],
});
}
if (hasOnlyOneArgument(node)) {
context.report({
messageId: 'unimplementedTest',
node,
fix: fixer => [createTodoFixer(node, fixer)],
});
}
},
};
},
});