Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
feat(no-focused-tests): make fixable (#787)
  • Loading branch information
alagane committed Mar 9, 2021
1 parent 613161f commit 040871a
Show file tree
Hide file tree
Showing 3 changed files with 323 additions and 29 deletions.
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -143,7 +143,7 @@ installations requiring long-term consistency.
| [no-done-callback](docs/rules/no-done-callback.md) | Avoid using a callback in asynchronous tests and hooks | ![recommended][] | ![suggest][] |
| [no-duplicate-hooks](docs/rules/no-duplicate-hooks.md) | Disallow duplicate setup and teardown hooks | | |
| [no-export](docs/rules/no-export.md) | Disallow using `exports` in files containing tests | ![recommended][] | |
| [no-focused-tests](docs/rules/no-focused-tests.md) | Disallow focused tests | ![recommended][] | ![fixable][] |
| [no-focused-tests](docs/rules/no-focused-tests.md) | Disallow focused tests | ![recommended][] | ![suggest][] |
| [no-hooks](docs/rules/no-hooks.md) | Disallow setup and teardown hooks | | |
| [no-identical-title](docs/rules/no-identical-title.md) | Disallow identical titles | ![recommended][] | |
| [no-if](docs/rules/no-if.md) | Disallow conditional logic | | |
Expand Down
266 changes: 247 additions & 19 deletions src/rules/__tests__/no-focused-tests.test.ts
Expand Up @@ -31,79 +31,307 @@ ruleTester.run('no-focused-tests', rule, {
invalid: [
{
code: 'describe.only()',
errors: [{ messageId: 'focusedTest', column: 10, line: 1 }],
errors: [
{
messageId: 'focusedTest',
column: 10,
line: 1,
suggestions: [
{
messageId: 'suggestRemoveFocus',
output: 'describe()',
},
],
},
],
},
{
code: 'describe.only.each()',
errors: [{ messageId: 'focusedTest', column: 10, line: 1 }],
errors: [
{
messageId: 'focusedTest',
column: 10,
line: 1,
suggestions: [
{
messageId: 'suggestRemoveFocus',
output: 'describe.each()',
},
],
},
],
},
{
code: 'describe.only.each`table`()',
errors: [{ messageId: 'focusedTest', column: 10, line: 1 }],
errors: [
{
messageId: 'focusedTest',
column: 10,
line: 1,
suggestions: [
{
messageId: 'suggestRemoveFocus',
output: 'describe.each`table`()',
},
],
},
],
},
{
code: 'describe["only"]()',
errors: [{ messageId: 'focusedTest', column: 10, line: 1 }],
errors: [
{
messageId: 'focusedTest',
column: 10,
line: 1,
suggestions: [
{
messageId: 'suggestRemoveFocus',
output: 'describe()',
},
],
},
],
},
{
code: 'it.only()',
errors: [{ messageId: 'focusedTest', column: 4, line: 1 }],
errors: [
{
messageId: 'focusedTest',
column: 4,
line: 1,
suggestions: [
{
messageId: 'suggestRemoveFocus',
output: 'it()',
},
],
},
],
},
{
code: 'it.concurrent.only()',
errors: [{ messageId: 'focusedTest', column: 4, line: 1 }],
errors: [
{
messageId: 'focusedTest',
column: 4,
line: 1,
suggestions: [
{
messageId: 'suggestRemoveFocus',
output: 'it.concurrent()',
},
],
},
],
},
{
code: 'it.only.each()',
errors: [{ messageId: 'focusedTest', column: 4, line: 1 }],
errors: [
{
messageId: 'focusedTest',
column: 4,
line: 1,
suggestions: [
{
messageId: 'suggestRemoveFocus',
output: 'it.each()',
},
],
},
],
},
{
code: 'it.only.each`table`()',
errors: [{ messageId: 'focusedTest', column: 4, line: 1 }],
errors: [
{
messageId: 'focusedTest',
column: 4,
line: 1,
suggestions: [
{
messageId: 'suggestRemoveFocus',
output: 'it.each`table`()',
},
],
},
],
},
{
code: 'it["only"]()',
errors: [{ messageId: 'focusedTest', column: 4, line: 1 }],
errors: [
{
messageId: 'focusedTest',
column: 4,
line: 1,
suggestions: [
{
messageId: 'suggestRemoveFocus',
output: 'it()',
},
],
},
],
},
{
code: 'test.only()',
errors: [{ messageId: 'focusedTest', column: 6, line: 1 }],
errors: [
{
messageId: 'focusedTest',
column: 6,
line: 1,
suggestions: [
{
messageId: 'suggestRemoveFocus',
output: 'test()',
},
],
},
],
},
{
code: 'test.concurrent.only()',
errors: [{ messageId: 'focusedTest', column: 6, line: 1 }],
errors: [
{
messageId: 'focusedTest',
column: 6,
line: 1,
suggestions: [
{
messageId: 'suggestRemoveFocus',
output: 'test.concurrent()',
},
],
},
],
},
{
code: 'test.only.each()',
errors: [{ messageId: 'focusedTest', column: 6, line: 1 }],
errors: [
{
messageId: 'focusedTest',
column: 6,
line: 1,
suggestions: [
{
messageId: 'suggestRemoveFocus',
output: 'test.each()',
},
],
},
],
},
{
code: 'test.only.each`table`()',
errors: [{ messageId: 'focusedTest', column: 6, line: 1 }],
errors: [
{
messageId: 'focusedTest',
column: 6,
line: 1,
suggestions: [
{
messageId: 'suggestRemoveFocus',
output: 'test.each`table`()',
},
],
},
],
},
{
code: 'test["only"]()',
errors: [{ messageId: 'focusedTest', column: 6, line: 1 }],
errors: [
{
messageId: 'focusedTest',
column: 6,
line: 1,
suggestions: [
{
messageId: 'suggestRemoveFocus',
output: 'test()',
},
],
},
],
},
{
code: 'fdescribe()',
errors: [{ messageId: 'focusedTest', column: 1, line: 1 }],
errors: [
{
messageId: 'focusedTest',
column: 1,
line: 1,
suggestions: [
{
messageId: 'suggestRemoveFocus',
output: 'describe()',
},
],
},
],
},
{
code: 'fit()',
errors: [{ messageId: 'focusedTest', column: 1, line: 1 }],
errors: [
{
messageId: 'focusedTest',
column: 1,
line: 1,
suggestions: [
{
messageId: 'suggestRemoveFocus',
output: 'it()',
},
],
},
],
},
{
code: 'fit.each()',
errors: [{ messageId: 'focusedTest', column: 1, line: 1 }],
errors: [
{
messageId: 'focusedTest',
column: 1,
line: 1,
suggestions: [
{
messageId: 'suggestRemoveFocus',
output: 'it.each()',
},
],
},
],
},
{
code: 'fit.each`table`()',
errors: [{ messageId: 'focusedTest', column: 1, line: 1 }],
errors: [
{
messageId: 'focusedTest',
column: 1,
line: 1,
suggestions: [
{
messageId: 'suggestRemoveFocus',
output: 'it.each`table`()',
},
],
},
],
},
{
code: 'ftest.each`table`()',
errors: [{ messageId: 'focusedTest', column: 1, line: 1 }],
errors: [
{
messageId: 'focusedTest',
column: 1,
line: 1,
suggestions: [
{
messageId: 'suggestRemoveFocus',
output: 'test.each`table`()',
},
],
},
],
},
],
});

0 comments on commit 040871a

Please sign in to comment.