fix(add-no-commented-out): correct false positives (#271)

jest-community · May 22, 2019 · 1740ee7 · 1740ee7
1 parent 1ce1402
commit 1740ee7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/rules/__tests__/no-commented-out-tests.test.js b/src/rules/__tests__/no-commented-out-tests.test.js
@@ -24,6 +24,8 @@ ruleTester.run('no-commented-out-tests', rule, {
     '(a || b).f()',
     'itHappensToStartWithIt()',
     'testSomething()',
+    '// latest(dates)',
+    '// TODO: unify with Git implementation from Shipit (?)',
     [
       'import { pending } from "actions"',
       '',

diff --git a/src/rules/no-commented-out-tests.js b/src/rules/no-commented-out-tests.js
@@ -5,7 +5,7 @@ const { getDocsUrl } = require('./util');
 const message = 'Some tests seem to be commented';
 
 function hasTests(node) {
-  return /(x|f)?(test|it|describe)(\.\w+|\[['"]\w+['"]\])?\s*\(/m.test(
+  return /^\s*(x|f)?(test|it|describe)(\.\w+|\[['"]\w+['"]\])?\s*\(/m.test(
     node.value,
   );
 }