From 2eaed2bf30c72b03ee205910887f8aab304047a5 Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Sun, 17 May 2020 11:22:10 +1200 Subject: [PATCH] fix(prefer-strict-equal): provide suggestion instead of autofix --- .../__tests__/prefer-strict-equal.test.ts | 15 ++++++++++++-- src/rules/prefer-strict-equal.ts | 20 ++++++++++++------- 2 files changed, 26 insertions(+), 9 deletions(-) diff --git a/src/rules/__tests__/prefer-strict-equal.test.ts b/src/rules/__tests__/prefer-strict-equal.test.ts index 4b6bb4b1e..a47c42340 100644 --- a/src/rules/__tests__/prefer-strict-equal.test.ts +++ b/src/rules/__tests__/prefer-strict-equal.test.ts @@ -12,8 +12,19 @@ ruleTester.run('prefer-strict-equal', rule, { invalid: [ { code: 'expect(something).toEqual(somethingElse);', - errors: [{ messageId: 'useToStrictEqual', column: 19, line: 1 }], - output: 'expect(something).toStrictEqual(somethingElse);', + errors: [ + { + messageId: 'useToStrictEqual', + column: 19, + line: 1, + suggestions: [ + { + messageId: 'suggestReplaceWithStrictEqual', + output: 'expect(something).toStrictEqual(somethingElse);', + }, + ], + }, + ], }, ], }); diff --git a/src/rules/prefer-strict-equal.ts b/src/rules/prefer-strict-equal.ts index 1517a88db..af650f4dd 100644 --- a/src/rules/prefer-strict-equal.ts +++ b/src/rules/prefer-strict-equal.ts @@ -15,7 +15,8 @@ export default createRule({ recommended: false, }, messages: { - useToStrictEqual: 'Use toStrictEqual() instead', + useToStrictEqual: 'Use `toStrictEqual()` instead', + suggestReplaceWithStrictEqual: 'Replace with `toStrictEqual()`', }, fixable: 'code', type: 'suggestion', @@ -36,14 +37,19 @@ export default createRule({ isParsedEqualityMatcherCall(matcher, EqualityMatcher.toEqual) ) { context.report({ - fix: fixer => [ - fixer.replaceText( - matcher.node.property, - EqualityMatcher.toStrictEqual, - ), - ], messageId: 'useToStrictEqual', node: matcher.node.property, + suggest: [ + { + messageId: 'suggestReplaceWithStrictEqual', + fix: fixer => [ + fixer.replaceText( + matcher.node.property, + EqualityMatcher.toStrictEqual, + ), + ], + }, + ], }); } },