fix: don't consider template tags in the middle of a possible jest fu…

…nction chain to be valid (#1133)
jest-community · May 29, 2022 · 430de17 · 430de17
1 parent 44de2ad
commit 430de17
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/src/rules/utils/__tests__/parseJestFnCall.test.ts b/src/rules/utils/__tests__/parseJestFnCall.test.ts
@@ -118,6 +118,9 @@ ruleTester.run('nonexistent methods', rule, {
     '"something".describe()',
     '[].describe()',
     'new describe().only()',
+    '``.test()',
+    'test.only``()',
+    'test``.only()',
   ],
   invalid: [],
 });

diff --git a/src/rules/utils/parseJestFnCall.ts b/src/rules/utils/parseJestFnCall.ts
@@ -160,21 +160,21 @@ export const parseJestFnCall = (
     return null;
   }
 
-  // ensure that the only call expression in the chain is at the end
+  // check that every link in the chain except the last is a member expression
   if (
     chain
       .slice(0, chain.length - 1)
-      .some(nod => nod.parent?.type === AST_NODE_TYPES.CallExpression)
+      .some(nod => nod.parent?.type !== AST_NODE_TYPES.MemberExpression)
   ) {
     return null;
   }
 
   const [first, ...rest] = chain;
 
-  const lastNode = chain[chain.length - 1];
+  const lastLink = getAccessorValue(chain[chain.length - 1]);
 
   // if we're an `each()`, ensure we're the outer CallExpression (i.e `.each()()`)
-  if (isSupportedAccessor(lastNode, 'each')) {
+  if (lastLink === 'each') {
     if (
       node.callee.type !== AST_NODE_TYPES.CallExpression &&
       node.callee.type !== AST_NODE_TYPES.TaggedTemplateExpression
@@ -183,6 +183,13 @@ export const parseJestFnCall = (
     }
   }
 
+  if (
+    node.callee.type === AST_NODE_TYPES.TaggedTemplateExpression &&
+    lastLink !== 'each'
+  ) {
+    return null;
+  }
+
   const resolved = resolveToJestFn(scope, getAccessorValue(first));
 
   // we're not a jest function