fix(valid-expect-in-promise): fix type exception

Fixes #195
jest-community · Nov 6, 2018 · 60919f6 · 60919f6
1 parent 02cd21a
commit 60919f6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/rules/__tests__/valid-expect-in-promise.test.js b/rules/__tests__/valid-expect-in-promise.test.js
@@ -182,6 +182,15 @@ ruleTester.run('valid-expect-in-promise', rule, {
   ],
 
   valid: [
+    `
+      it('it1', () => new Promise((done) => {
+        test()
+          .then(() => {
+            expect(someThing).toEqual(true);
+            done();
+          });
+      }));
+    `,
     `
       it('it1', () => {
         return somePromise.then(() => {

diff --git a/rules/valid-expect-in-promise.js b/rules/valid-expect-in-promise.js
@@ -88,6 +88,7 @@ const getTestFunction = node => {
 const isParentThenOrPromiseReturned = (node, testFunctionBody) => {
   return (
     testFunctionBody.type === 'CallExpression' ||
+    testFunctionBody.type === 'NewExpression' ||
     node.parent.parent.type === 'ReturnStatement' ||
     isPromiseReturnedLater(node, testFunctionBody) ||
     isThenOrCatch(node.parent.parent)