From 624018aa181e7c0ce87457a4f9c212c7891987a8 Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Tue, 23 Jun 2020 22:35:53 +1200 Subject: [PATCH] fix(lowercase-name): ignore all top level describes when option is true (#614) closes #613 --- src/rules/__tests__/lowercase-name.test.ts | 16 ++++++++++++++++ src/rules/lowercase-name.ts | 5 +++++ 2 files changed, 21 insertions(+) diff --git a/src/rules/__tests__/lowercase-name.test.ts b/src/rules/__tests__/lowercase-name.test.ts index 3b29d1f77..ac3c7fe5d 100644 --- a/src/rules/__tests__/lowercase-name.test.ts +++ b/src/rules/__tests__/lowercase-name.test.ts @@ -271,6 +271,22 @@ ruleTester.run('lowercase-name with ignoreTopLevelDescribe', rule, { `, options: [{ ignoreTopLevelDescribe: true }], }, + { + code: dedent` + describe('Strings', () => { + it('are strings', () => { + expect('abc').toBe('abc'); + }); + }); + + describe('Booleans', () => { + it('are booleans', () => { + expect(true).toBe(true); + }); + }); + `, + options: [{ ignoreTopLevelDescribe: true }], + }, ], invalid: [ { diff --git a/src/rules/lowercase-name.ts b/src/rules/lowercase-name.ts index c79083010..5c9cb9e41 100644 --- a/src/rules/lowercase-name.ts +++ b/src/rules/lowercase-name.ts @@ -158,6 +158,11 @@ export default createRule< }); } }, + 'CallExpression:exit'(node: TSESTree.CallExpression) { + if (isDescribe(node)) { + numberOfDescribeBlocks--; + } + }, }; }, });