From 63472e2bcd3f3ab74d117e399a6d88b676a94b4d Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Fri, 1 Nov 2019 10:09:09 +1300 Subject: [PATCH] fix(valid-describe): don't check arguments of describe.each Fixes #463 --- src/rules/__tests__/valid-describe.test.ts | 1 + src/rules/valid-describe.ts | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/rules/__tests__/valid-describe.test.ts b/src/rules/__tests__/valid-describe.test.ts index e38a8c836..20bb40a99 100644 --- a/src/rules/__tests__/valid-describe.test.ts +++ b/src/rules/__tests__/valid-describe.test.ts @@ -16,6 +16,7 @@ ruleTester.run('valid-describe', rule, { 'describe["each"](() => {})("foo")', 'describe["each"]()(() => {})', 'describe["each"]("foo")(() => {})', + 'describe.each([1, 2, 3])("%s", (a, b) => {});', 'describe("foo", function() {})', 'describe("foo", () => {})', 'describe(`foo`, () => {})', diff --git a/src/rules/valid-describe.ts b/src/rules/valid-describe.ts index d2a8ad83d..6815f9221 100644 --- a/src/rules/valid-describe.ts +++ b/src/rules/valid-describe.ts @@ -6,6 +6,7 @@ import { createRule, getJestFunctionArguments, isDescribe, + isDescribeEach, isFunction, } from './utils'; @@ -85,7 +86,7 @@ export default createRule({ }); } - if (callback.params.length) { + if (!isDescribeEach(node) && callback.params.length) { context.report({ messageId: 'unexpectedDescribeArgument', loc: paramsLocation(callback.params),