From 6a32e870c016474687e238944933a96bfe1ca01b Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Sun, 7 Mar 2021 08:39:24 +1300 Subject: [PATCH] fix(no-disabled-tests): support `describe.skip.each` & `xdescribe.each` (#778) --- src/rules/__tests__/no-disabled-tests.test.ts | 8 ++++++++ src/rules/no-disabled-tests.ts | 2 ++ 2 files changed, 10 insertions(+) diff --git a/src/rules/__tests__/no-disabled-tests.test.ts b/src/rules/__tests__/no-disabled-tests.test.ts index 4d8118bd3..45fca5457 100644 --- a/src/rules/__tests__/no-disabled-tests.test.ts +++ b/src/rules/__tests__/no-disabled-tests.test.ts @@ -67,6 +67,14 @@ ruleTester.run('no-disabled-tests', rule, { code: 'describe.skip("foo", function () {})', errors: [{ messageId: 'skippedTestSuite', column: 1, line: 1 }], }, + { + code: 'describe.skip.each([1, 2, 3])("%s", (a, b) => {});', + errors: [{ messageId: 'skippedTestSuite', column: 1, line: 1 }], + }, + { + code: 'xdescribe.each([1, 2, 3])("%s", (a, b) => {});', + errors: [{ messageId: 'skippedTestSuite', column: 1, line: 1 }], + }, { code: 'describe[`skip`]("foo", function () {})', errors: [{ messageId: 'skippedTestSuite', column: 1, line: 1 }], diff --git a/src/rules/no-disabled-tests.ts b/src/rules/no-disabled-tests.ts index b6b5490f6..1ce0d6bf4 100644 --- a/src/rules/no-disabled-tests.ts +++ b/src/rules/no-disabled-tests.ts @@ -45,6 +45,8 @@ export default createRule({ } switch (functionName) { + case 'describe.skip.each': + case 'xdescribe.each': case 'describe.skip': context.report({ messageId: 'skippedTestSuite', node }); break;