feat: set no-jasmine-globals to error in recommended ruleset

BREAKING CHANGE: recommend erroring for `no-jasmine-globals` rule
jest-community · Sep 4, 2020 · 7080952 · 7080952
1 parent 22113db
commit 7080952
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/__tests__/__snapshots__/rules.test.ts.snap b/src/__tests__/__snapshots__/rules.test.ts.snap
@@ -70,7 +70,7 @@ Object {
       "jest/no-export": "error",
       "jest/no-focused-tests": "error",
       "jest/no-identical-title": "error",
-      "jest/no-jasmine-globals": "warn",
+      "jest/no-jasmine-globals": "error",
       "jest/no-jest-import": "error",
       "jest/no-mocks-import": "error",
       "jest/no-standalone-expect": "error",

diff --git a/src/rules/no-jasmine-globals.ts b/src/rules/no-jasmine-globals.ts
@@ -12,7 +12,7 @@ export default createRule({
     docs: {
       category: 'Best Practices',
       description: 'Disallow Jasmine globals',
-      recommended: 'warn',
+      recommended: 'error',
     },
     messages: {
       illegalGlobal: