From 7080952a6baaae7a02c78f60016ee21693121416 Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Fri, 31 Jul 2020 10:40:04 +1200 Subject: [PATCH] feat: set `no-jasmine-globals` to `error` in recommended ruleset BREAKING CHANGE: recommend erroring for `no-jasmine-globals` rule --- src/__tests__/__snapshots__/rules.test.ts.snap | 2 +- src/rules/no-jasmine-globals.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/__tests__/__snapshots__/rules.test.ts.snap b/src/__tests__/__snapshots__/rules.test.ts.snap index d82ca52e3..72f66320f 100644 --- a/src/__tests__/__snapshots__/rules.test.ts.snap +++ b/src/__tests__/__snapshots__/rules.test.ts.snap @@ -70,7 +70,7 @@ Object { "jest/no-export": "error", "jest/no-focused-tests": "error", "jest/no-identical-title": "error", - "jest/no-jasmine-globals": "warn", + "jest/no-jasmine-globals": "error", "jest/no-jest-import": "error", "jest/no-mocks-import": "error", "jest/no-standalone-expect": "error", diff --git a/src/rules/no-jasmine-globals.ts b/src/rules/no-jasmine-globals.ts index eebb5bfa0..a742f9ac8 100644 --- a/src/rules/no-jasmine-globals.ts +++ b/src/rules/no-jasmine-globals.ts @@ -12,7 +12,7 @@ export default createRule({ docs: { category: 'Best Practices', description: 'Disallow Jasmine globals', - recommended: 'warn', + recommended: 'error', }, messages: { illegalGlobal: