fix(max-expects): don't count expect.<member>() calls towards max (#…

…1194)
jest-community · Aug 9, 2022 · 75a0ff2 · 75a0ff2
1 parent 4106b8f
commit 75a0ff2
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 2 deletions.
diff --git a/src/rules/__tests__/max-expects.test.ts b/src/rules/__tests__/max-expects.test.ts
@@ -57,6 +57,37 @@ ruleTester.run('max-expects', rule, {
         expect(true).toBeDefined();
       });
     `,
+    dedent`
+      test('should pass', async () => {
+        expect.hasAssertions();
+
+        expect(true).toBeDefined();
+        expect(true).toBeDefined();
+        expect(true).toBeDefined();
+        expect(true).toBeDefined();
+        expect(true).toBeDefined();
+      });
+    `,
+    dedent`
+      test('should pass', async () => {
+        expect(true).toBeDefined();
+        expect(true).toBeDefined();
+        expect(true).toBeDefined();
+        expect(true).toBeDefined();
+        expect(true).toEqual(expect.any(Boolean));
+      });
+    `,
+    dedent`
+      test('should pass', async () => {
+        expect.hasAssertions();
+
+        expect(true).toBeDefined();
+        expect(true).toBeDefined();
+        expect(true).toBeDefined();
+        expect(true).toBeDefined();
+        expect(true).toEqual(expect.any(Boolean));
+      });
+    `,
     dedent`
       describe('test', () => {
         test('should pass', () => {

diff --git a/src/rules/max-expects.ts b/src/rules/max-expects.ts
@@ -1,5 +1,10 @@
 import { AST_NODE_TYPES } from '@typescript-eslint/utils';
-import { FunctionExpression, createRule, isTypeOfJestFnCall } from './utils';
+import {
+  FunctionExpression,
+  createRule,
+  isTypeOfJestFnCall,
+  parseJestFnCall,
+} from './utils';
 
 export default createRule({
   name: __filename,
@@ -45,7 +50,12 @@ export default createRule({
       FunctionExpression: onFunctionExpressionEnter,
       ArrowFunctionExpression: onFunctionExpressionEnter,
       CallExpression(node) {
-        if (!isTypeOfJestFnCall(node, context, ['expect'])) {
+        const jestFnCall = parseJestFnCall(node, context);
+
+        if (
+          jestFnCall?.type !== 'expect' ||
+          jestFnCall.head.node.parent?.type === AST_NODE_TYPES.MemberExpression
+        ) {
           return;
         }