fix(valid-title): ensure argument node is defined before accessing pr…

…ops (#538)
jest-community · Feb 23, 2020 · 7730f75 · 7730f75
1 parent 5d8be9d
commit 7730f75
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/rules/__tests__/valid-title.test.ts b/src/rules/__tests__/valid-title.test.ts
@@ -271,6 +271,7 @@ ruleTester.run('no-empty-title', rule, {
     'test(`${foo}`, function () {})',
     'test.concurrent(`${foo}`, function () {})',
     "it('foo', function () {})",
+    'it.each([])()',
     "it.concurrent('foo', function () {})",
     "xdescribe('foo', function () {})",
     "xit('foo', function () {})",

diff --git a/src/rules/valid-title.ts b/src/rules/valid-title.ts
@@ -81,12 +81,16 @@ export default createRule({
 
     return {
       CallExpression(node: TSESTree.CallExpression) {
-        if (!(isDescribe(node) || isTestCase(node)) || !node.arguments.length) {
+        if (!isDescribe(node) && !isTestCase(node)) {
           return;
         }
 
         const [argument] = getJestFunctionArguments(node);
 
+        if (!argument) {
+          return;
+        }
+
         if (!isStringNode(argument)) {
           if (
             argument.type === AST_NODE_TYPES.BinaryExpression &&