From 87e29fc8cc2dd061421c4772083c8e11bb8f61da Mon Sep 17 00:00:00 2001
From: Gareth Jones <jones258@gmail.com>
Date: Wed, 9 Sep 2020 00:02:21 +1200
Subject: [PATCH] fix: don't include deprecated rules in `all` config

Resolves #663
---
 src/__tests__/rules.test.ts |  7 +++++--
 src/index.ts                | 12 +++++++++---
 2 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/src/__tests__/rules.test.ts b/src/__tests__/rules.test.ts
index 550353f1c..d37e1bd4a 100644
--- a/src/__tests__/rules.test.ts
+++ b/src/__tests__/rules.test.ts
@@ -2,8 +2,11 @@ import { existsSync } from 'fs';
 import { resolve } from 'path';
 import plugin from '../';
 
-const ruleNames = Object.keys(plugin.rules);
 const numberOfRules = 44;
+const ruleNames = Object.keys(plugin.rules);
+const deprecatedRules = Object.entries(plugin.rules)
+  .filter(([, rule]) => rule.meta.deprecated)
+  .map(([name]) => name);
 
 describe('rules', () => {
   it('should have a corresponding doc for each rule', () => {
@@ -54,7 +57,7 @@ describe('rules', () => {
       'style',
     ]);
     expect(Object.keys(recommendedConfigs.all.rules)).toHaveLength(
-      ruleNames.length,
+      ruleNames.length - deprecatedRules.length,
     );
     const allConfigRules = Object.values(recommendedConfigs)
       .map(config => Object.keys(config.rules))
diff --git a/src/index.ts b/src/index.ts
index 79923412b..6ae0e5b54 100644
--- a/src/index.ts
+++ b/src/index.ts
@@ -48,9 +48,15 @@ const recommendedRules = Object.entries(rules)
     {},
   );
 
-const allRules = Object.keys(rules).reduce<
-  Record<string, TSESLint.Linter.RuleLevel>
->((rules, key) => ({ ...rules, [`jest/${key}`]: 'error' }), {});
+const allRules = Object.entries(rules)
+  // .filter(([, rule]) => !rule.meta.deprecated)
+  .reduce(
+    (acc, [name]) => ({
+      ...acc,
+      [`jest/${name}`]: 'error',
+    }),
+    {},
+  );
 
 const createConfig = (rules: Record<string, TSESLint.Linter.RuleLevel>) => ({
   plugins: ['jest'],