From 8b61b0c0dd79e8f3a83cbbd78eada2bc8dee52e8 Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Sat, 23 Apr 2022 11:41:16 +1200 Subject: [PATCH] fix(prefer-expect-assertions): properly handle checking across multiple tests (#1089) --- .../__tests__/prefer-expect-assertions.test.ts | 14 ++++++++++++++ src/rules/prefer-expect-assertions.ts | 2 ++ 2 files changed, 16 insertions(+) diff --git a/src/rules/__tests__/prefer-expect-assertions.test.ts b/src/rules/__tests__/prefer-expect-assertions.test.ts index 6e56295ec..ceee711b1 100644 --- a/src/rules/__tests__/prefer-expect-assertions.test.ts +++ b/src/rules/__tests__/prefer-expect-assertions.test.ts @@ -816,6 +816,20 @@ ruleTester.run('prefer-expect-assertions (callbacks)', rule, { `, options: [{ onlyFunctionsWithExpectInCallback: true }], }, + { + code: dedent` + it('is a test', () => { + expect(expected).toBe(actual); + }); + + describe('my test', () => { + it('is another test', () => { + expect(expected).toBe(actual); + }); + }); + `, + options: [{ onlyFunctionsWithExpectInCallback: true }], + }, ], invalid: [ { diff --git a/src/rules/prefer-expect-assertions.ts b/src/rules/prefer-expect-assertions.ts index 1b73fe8b4..99ca8a770 100644 --- a/src/rules/prefer-expect-assertions.ts +++ b/src/rules/prefer-expect-assertions.ts @@ -178,6 +178,8 @@ export default createRule<[RuleOptions], MessageIds>({ return; } + inTestCaseCall = false; + if (node.arguments.length < 2) { return; }