From 9b5939e923af67a0224721ed5fc5cb28cafd5336 Mon Sep 17 00:00:00 2001 From: Jack Franklin Date: Mon, 15 Oct 2018 17:02:35 +0100 Subject: [PATCH] fix(no-disabled-tests): stop picking up all funcs that start it/test --- rules/__tests__/no-disabled-tests.test.js | 2 ++ rules/no-disabled-tests.js | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/rules/__tests__/no-disabled-tests.test.js b/rules/__tests__/no-disabled-tests.test.js index 0ba7aa4df..253ae00e0 100644 --- a/rules/__tests__/no-disabled-tests.test.js +++ b/rules/__tests__/no-disabled-tests.test.js @@ -21,6 +21,8 @@ ruleTester.run('no-disabled-tests', rule, { 'var calledSkip = it.skip; calledSkip.call(it)', '({ f: function () {} }).f()', '(a || b).f()', + 'itHappensToStartWithIt()', + 'testSomething()', [ 'import { pending } from "actions"', '', diff --git a/rules/no-disabled-tests.js b/rules/no-disabled-tests.js index 307e643e6..10778fc47 100644 --- a/rules/no-disabled-tests.js +++ b/rules/no-disabled-tests.js @@ -44,10 +44,10 @@ module.exports = { 'CallExpression[callee.name="describe"]'() { suiteDepth++; }, - 'CallExpression[callee.name=/^it|test$/]'() { + 'CallExpression[callee.name=/^(it|test)$/]'() { testDepth++; }, - 'CallExpression[callee.name=/^it|test$/][arguments.length<2]'(node) { + 'CallExpression[callee.name=/^(it|test)$/][arguments.length<2]'(node) { context.report({ message: 'Test is missing function argument', node,