fix: add defined guards to util functions (#285)

jest-community · Jun 22, 2019 · 9cba626 · 9cba626
1 parent d7a9532
commit 9cba626
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/src/rules/__tests__/no-empty-title.js b/src/rules/__tests__/no-empty-title.js
@@ -11,6 +11,7 @@ const ruleTester = new RuleTester({
 
 ruleTester.run('no-empty-title', rule, {
   valid: [
+    'describe()',
     'someFn("", function () {})',
     'describe(1, function () {})',
     'describe("foo", function () {})',

diff --git a/src/rules/util.js b/src/rules/util.js
@@ -125,18 +125,24 @@ const isTestCase = node =>
   testCaseNames[getNodeName(node.callee)];
 
 const isDescribe = node =>
-  node.type === 'CallExpression' && describeAliases[getNodeName(node.callee)];
+  node &&
+  node.type === 'CallExpression' &&
+  describeAliases[getNodeName(node.callee)];
 
 const isFunction = node =>
-  node.type === 'FunctionExpression' || node.type === 'ArrowFunctionExpression';
+  node &&
+  (node.type === 'FunctionExpression' ||
+    node.type === 'ArrowFunctionExpression');
 
 const isString = node =>
-  (node.type === 'Literal' && typeof node.value === 'string') ||
-  isTemplateLiteral(node);
+  node &&
+  ((node.type === 'Literal' && typeof node.value === 'string') ||
+    isTemplateLiteral(node));
 
-const isTemplateLiteral = node => node.type === 'TemplateLiteral';
+const isTemplateLiteral = node => node && node.type === 'TemplateLiteral';
 
-const hasExpressions = node => node.expressions && node.expressions.length > 0;
+const hasExpressions = node =>
+  node && node.expressions && node.expressions.length > 0;
 
 const getStringValue = arg =>
   isTemplateLiteral(arg) ? arg.quasis[0].value.raw : arg.value;