fix: prefer hasOwnProperty over in

Fixes #334
jest-community · Jul 22, 2019 · b27c80d · b27c80d · SimenB · Jul 22, 2019
1 parent 7f1867b
commit b27c80d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/src/rules/__tests__/valid-describe.test.ts b/src/rules/__tests__/valid-describe.test.ts
@@ -38,6 +38,10 @@ ruleTester.run('valid-describe', rule, {
       test('bar', () => {})
     )
     `,
+    `
+    if (hasOwnProperty(obj, key)) {
+    }
+    `,
   ],
   invalid: [
     {

diff --git a/src/rules/tsUtils.ts b/src/rules/tsUtils.ts
@@ -166,7 +166,7 @@ export const isHook = (
 ): node is JestFunctionCallExpressionWithIdentifierCallee<HookName> => {
   return (
     node.callee.type === AST_NODE_TYPES.Identifier &&
-    node.callee.name in HookName
+    HookName.hasOwnProperty(node.callee.name)
   );
 };
 
@@ -175,10 +175,10 @@ export const isTestCase = (
 ): node is JestFunctionCallExpression<TestCaseName> => {
   return (
     (node.callee.type === AST_NODE_TYPES.Identifier &&
-      node.callee.name in TestCaseName) ||
+      TestCaseName.hasOwnProperty(node.callee.name)) ||
     (node.callee.type === AST_NODE_TYPES.MemberExpression &&
       node.callee.object.type === AST_NODE_TYPES.Identifier &&
-      node.callee.object.name in TestCaseName)
+      TestCaseName.hasOwnProperty(node.callee.object.name))
   );
 };
 
@@ -187,10 +187,10 @@ export const isDescribe = (
 ): node is JestFunctionCallExpression<DescribeAlias> => {
   return (
     (node.callee.type === AST_NODE_TYPES.Identifier &&
-      node.callee.name in DescribeAlias) ||
+      DescribeAlias.hasOwnProperty(node.callee.name)) ||
     (node.callee.type === AST_NODE_TYPES.MemberExpression &&
       node.callee.object.type === AST_NODE_TYPES.Identifier &&
-      node.callee.object.name in DescribeAlias)
+      DescribeAlias.hasOwnProperty(node.callee.object.name))
   );
 };