From b651443b820126cf05ad6803648c789afde0172f Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Tue, 31 May 2022 06:35:29 +1200 Subject: [PATCH] fix(no-disabled-tests): don't report on `it.todo` & `test.todo` (#1137) --- src/rules/__tests__/no-disabled-tests.test.ts | 1 + src/rules/no-disabled-tests.ts | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/rules/__tests__/no-disabled-tests.test.ts b/src/rules/__tests__/no-disabled-tests.test.ts index 5287aab1d..b331767ba 100644 --- a/src/rules/__tests__/no-disabled-tests.test.ts +++ b/src/rules/__tests__/no-disabled-tests.test.ts @@ -23,6 +23,7 @@ ruleTester.run('no-disabled-tests', rule, { 'test.only("foo", function () {})', 'test.concurrent("foo", function () {})', 'describe[`${"skip"}`]("foo", function () {})', + 'it.todo("fill this later")', 'var appliedSkip = describe.skip; appliedSkip.apply(describe)', 'var calledSkip = it.skip; calledSkip.call(it)', '({ f: function () {} }).f()', diff --git a/src/rules/no-disabled-tests.ts b/src/rules/no-disabled-tests.ts index 9466ae92d..e8c779c9d 100644 --- a/src/rules/no-disabled-tests.ts +++ b/src/rules/no-disabled-tests.ts @@ -44,7 +44,10 @@ export default createRule({ if (jestFnCall.type === 'test') { testDepth++; - if (node.arguments.length < 2) { + if ( + node.arguments.length < 2 && + jestFnCall.members.every(s => getAccessorValue(s) !== 'todo') + ) { context.report({ messageId: 'missingFunction', node }); } }