From d8963028b3115e26cd824c4ee5ddcddab405774e Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Tue, 6 Aug 2019 22:31:49 +1200 Subject: [PATCH] chore(valid-expect): swap early return for smaller body --- src/rules/valid-expect.ts | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/rules/valid-expect.ts b/src/rules/valid-expect.ts index e491ff71f..3b21c11e7 100644 --- a/src/rules/valid-expect.ts +++ b/src/rules/valid-expect.ts @@ -281,16 +281,11 @@ export default createRule<[{ alwaysAwait?: boolean }], MessageIds>({ // nothing called on "expect()" 'CallExpression:exit'(node: TSESTree.CallExpression) { if ( - !isExpectCall(node) || - node.parent.type !== AST_NODE_TYPES.ExpressionStatement + isExpectCall(node) && + node.parent.type === AST_NODE_TYPES.ExpressionStatement ) { - return; + context.report({ messageId: 'noAssertions', node }); } - - context.report({ - messageId: 'noAssertions', - node, - }); }, }; },