From e0a36e2d67ce231ba9244d0aa655f36b0fb610a6 Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Fri, 6 Mar 2020 13:34:18 +1300 Subject: [PATCH] fix(prefer-to-contain): check that expect argument is defined before use --- src/rules/__tests__/prefer-to-contain.test.ts | 1 + src/rules/prefer-to-contain.ts | 1 + 2 files changed, 2 insertions(+) diff --git a/src/rules/__tests__/prefer-to-contain.test.ts b/src/rules/__tests__/prefer-to-contain.test.ts index 8fa369bc8..2077d3710 100644 --- a/src/rules/__tests__/prefer-to-contain.test.ts +++ b/src/rules/__tests__/prefer-to-contain.test.ts @@ -5,6 +5,7 @@ const ruleTester = new TSESLint.RuleTester(); ruleTester.run('prefer-to-contain', rule, { valid: [ + 'expect().toBe(false);', 'expect(a).toContain(b);', "expect(a.name).toBe('b');", 'expect(a).toBe(true);', diff --git a/src/rules/prefer-to-contain.ts b/src/rules/prefer-to-contain.ts index 4fd516e3a..11ad3435c 100644 --- a/src/rules/prefer-to-contain.ts +++ b/src/rules/prefer-to-contain.ts @@ -187,6 +187,7 @@ export default createRule({ if ( !matcher || + !includesCall || (modifier && modifier.name !== ModifierName.not) || !isBooleanEqualityMatcher(matcher) || !isFixableIncludesCallExpression(includesCall)