From e961e21e3314258660ec521d2bfaedf11823dbb1 Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Thu, 24 Oct 2019 08:42:55 +1300 Subject: [PATCH] fix(valid-title): check if node has arguments first (#436) --- src/rules/__tests__/valid-title.test.ts | 4 ++++ src/rules/valid-title.ts | 2 ++ 2 files changed, 6 insertions(+) diff --git a/src/rules/__tests__/valid-title.test.ts b/src/rules/__tests__/valid-title.test.ts index 5f4d7edb6..08d695315 100644 --- a/src/rules/__tests__/valid-title.test.ts +++ b/src/rules/__tests__/valid-title.test.ts @@ -9,6 +9,10 @@ const ruleTester = new TSESLint.RuleTester({ ruleTester.run('no-accidental-space', rule, { valid: [ + 'it()', + 'describe()', + 'it("")', + 'it.each()()', 'describe("foo", function () {})', 'describe(6, function () {})', 'fdescribe("foo", function () {})', diff --git a/src/rules/valid-title.ts b/src/rules/valid-title.ts index 3ba3dd787..4a89c9471 100644 --- a/src/rules/valid-title.ts +++ b/src/rules/valid-title.ts @@ -39,6 +39,8 @@ export default createRule({ CallExpression(node) { if (!isDescribe(node) && !isTestCase(node)) return; + if (!node.arguments.length) return; + const title = getNodeTitle(node); if (!title) return;