.git-blame-ignore-revs

@@ -0,0 +1,5 @@
+# See https://git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs-fileltfilegt
+# Run git config blame.ignoreRevsFile .git-blame-ignore-revs
+
+# prettier bumps
+fd946237c143f6cddb6ddb367a01ac2933f0b343

.github/renovate.json

@@ -1,6 +1,6 @@
 {
   "extends": ["config:base"],
-  "lockFileMaintenance": { "enabled": true },
+  "lockFileMaintenance": { "enabled": true, "automerge": true },
   "rangeStrategy": "replace",
   "postUpdateOptions": ["yarnDedupeHighest"]
 }

.github/workflows/lint.yml

@@ -18,6 +18,6 @@ jobs:
     steps:
       - uses: actions/checkout@v2
       - name: Danger
-        uses: danger/danger-js@10.6.4
+        uses: danger/danger-js@10.6.6
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/nodejs.yml

@@ -18,20 +18,11 @@ jobs:
     steps:
       - uses: actions/checkout@v2
 
-      - uses: actions/setup-node@v2.1.5
+      - uses: actions/setup-node@v2.2.0
         with:
           node-version: 14.x
+          cache: yarn
 
-      - name: Get yarn cache
-        id: yarn-cache
-        run: echo "::set-output name=dir::$(yarn config get cacheFolder)"
-
-      - uses: actions/cache@v2.1.5
-        with:
-          path: ${{ steps.yarn-cache.outputs.dir }}
-          key: yarn2-${{ hashFiles('yarn.lock') }}
-          restore-keys: |
-            yarn2-
       - name: Validate cache
         env:
           # Use PnP and disable postinstall scripts as this just needs to
@@ -40,10 +31,38 @@ jobs:
           YARN_ENABLE_SCRIPTS: false
         run: yarn --immutable
 
+  prettier:
+    needs: prepare-yarn-cache
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-node@v2.2.0
+        with:
+          node-version: 14.x
+          cache: yarn
+      - name: install
+        run: yarn
+      - name: run prettier
+        run: yarn prettier:check
+
+  typecheck:
+    needs: prepare-yarn-cache
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-node@v2.2.0
+        with:
+          node-version: 14.x
+          cache: yarn
+      - name: install
+        run: yarn
+      - name: run typecheck
+        run: yarn typecheck
+
   test-node:
     name:
       # prettier-ignore
-      Test on Node.js v${{ matrix.node-version }} and eslint v${{matrix.eslint-version }}
+      Test on Node.js v${{ matrix.node-version }} and eslint v${{ matrix.eslint-version }}
     needs: prepare-yarn-cache
     strategy:
       fail-fast: false
@@ -54,35 +73,21 @@ jobs:
 
     steps:
       - uses: actions/checkout@v2
-        with:
-          fetch-depth: 0
-      - name: Get yarn cache
-        id: yarn-cache
-        run: echo "::set-output name=dir::$(yarn config get cacheFolder)"
-      - uses: actions/cache@v2
-        with:
-          path: ${{ steps.yarn-cache.outputs.dir }}
-          key: yarn2-${{ hashFiles('yarn.lock') }}
-          restore-keys: |
-            yarn2-
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v2.1.5
+        uses: actions/setup-node@v2.2.0
         with:
           node-version: ${{ matrix.node-version }}
-      - name: install with eslint v${{matrix.eslint-version }}
+          cache: yarn
+      - name: install with eslint v${{ matrix.eslint-version }}
         run: |
           yarn
-          yarn add --dev eslint@${{matrix.eslint-version }}
-      - name: run prettier
-        run: yarn prettier:check
-      - name: run typecheck
-        run: yarn typecheck
+          yarn add --dev eslint@${{ matrix.eslint-version }}
       - name: run tests
         # only collect coverage on eslint versions that support the suggestions api
         run: yarn test --coverage ${{ matrix.eslint-version >= 6 }}
         env:
           CI: true
-      - uses: codecov/codecov-action@v1.3.2
+      - uses: codecov/codecov-action@v1.5.2
         if: ${{ matrix.eslint-version >= 6 }}
   test-os:
     name: Test on ${{ matrix.os }} using Node.js LTS
@@ -95,24 +100,12 @@ jobs:
 
     steps:
       - uses: actions/checkout@v2
-      - name: Get yarn cache
-        id: yarn-cache
-        run: echo "::set-output name=dir::$(yarn config get cacheFolder)"
-      - uses: actions/cache@v2
-        with:
-          path: ${{ steps.yarn-cache.outputs.dir }}
-          key: yarn2-${{ hashFiles('yarn.lock') }}
-          restore-keys: |
-            yarn2-
-      - uses: actions/setup-node@v2.1.5
+      - uses: actions/setup-node@v2.2.0
         with:
           node-version: 14.x
+          cache: yarn
       - name: install
         run: yarn
-      - name: run prettier
-        run: yarn prettier:check
-      - name: run typecheck
-        run: yarn typecheck
       - name: run tests
         run: yarn test --coverage
         env:
@@ -124,20 +117,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-        with:
-          fetch-depth: 0
-      - name: Get yarn cache
-        id: yarn-cache
-        run: echo "::set-output name=dir::$(yarn config get cacheFolder)"
-      - uses: actions/cache@v2
-        with:
-          path: ${{ steps.yarn-cache.outputs.dir }}
-          key: yarn2-${{ hashFiles('yarn.lock') }}
-          restore-keys: |
-            yarn2-
-      - uses: actions/setup-node@v2.1.5
+      - uses: actions/setup-node@v2.2.0
         with:
           node-version: 14.x
+          cache: yarn
       - name: install
         run: yarn
       - name: regenerate docs
@@ -153,22 +136,14 @@ jobs:
       # prettier-ignore
       ${{ github.event_name == 'push' && github.event.ref == 'refs/heads/main' }}
     name: Release new version
-    needs: [test-node, test-os]
+    needs: [prettier, typecheck, test-node, test-os]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - name: Get yarn cache
-        id: yarn-cache
-        run: echo "::set-output name=dir::$(yarn config get cacheFolder)"
-      - uses: actions/cache@v2
-        with:
-          path: ${{ steps.yarn-cache.outputs.dir }}
-          key: yarn2-${{ hashFiles('yarn.lock') }}
-          restore-keys: |
-            yarn2-
-      - uses: actions/setup-node@v2.1.5
+      - uses: actions/setup-node@v2.2.0
         with:
           node-version: 14.x
+          cache: yarn
       - name: install
         run: yarn
       - run: yarn semantic-release

.prettierignore

@@ -0,0 +1,2 @@
+CHANGELOG.md
+src/rules/__tests__/fixtures/

.yarnrc.yml

@@ -6,4 +6,4 @@ plugins:
   - path: .yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs
     spec: '@yarnpkg/plugin-interactive-tools'
 
-yarnPath: .yarn/releases/yarn-2.4.1.cjs
+yarnPath: .yarn/releases/yarn-2.4.2.cjs

CHANGELOG.md

@@ -1,3 +1,10 @@
+## [24.3.7](https://github.com/jest-community/eslint-plugin-jest/compare/v24.3.6...v24.3.7) (2021-07-21)
+
+
+### Bug Fixes
+
+* **valid-describe:** report on concise-body arrow functions ([#863](https://github.com/jest-community/eslint-plugin-jest/issues/863)) ([71c5299](https://github.com/jest-community/eslint-plugin-jest/commit/71c5299b14cac6d85ba8f8bd939461503a60468f))
+
 ## [24.3.6](https://github.com/jest-community/eslint-plugin-jest/compare/v24.3.5...v24.3.6) (2021-04-26)
 
 

README.md

@@ -13,8 +13,8 @@
 
 ## Installation
 
-```
-$ yarn add --dev eslint eslint-plugin-jest
+```bash
+yarn add --dev eslint eslint-plugin-jest
 ```
 
 **Note:** If you installed ESLint globally then you must also install

docs/rules/unbound-method.md

@@ -27,7 +27,7 @@ are not using TypeScript.
   overrides: [
     {
       files: ['test/**'],
-      extends: ['jest'],
+      plugins: ['jest'],
       rules: {
         // you should turn the original rule off *only* for test files
         '@typescript-eslint/unbound-method': 'off',

docs/rules/valid-describe.md

@@ -43,6 +43,12 @@ describe('myFunction', () => {
     });
   });
 });
+
+// Returning a value from a describe block is not allowed
+describe('myFunction', () =>
+  it('returns a truthy value', () => {
+    expect(myFunction()).toBeTruthy();
+  }));
 ```
 
 The following patterns are not considered warnings:

package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-jest",
-  "version": "24.3.6",
+  "version": "24.3.7",
   "description": "Eslint rules for Jest",
   "keywords": [
     "eslint",
@@ -97,7 +97,7 @@
     "@types/prettier": "^2.0.0",
     "@typescript-eslint/eslint-plugin": "^4.0.1",
     "@typescript-eslint/parser": "^4.0.1",
-    "babel-jest": "^26.0.1",
+    "babel-jest": "^27.0.0",
     "babel-plugin-replace-ts-export-assignment": "^0.0.2",
     "dedent": "^0.7.0",
     "eslint": "^5.1.0 || ^6.0.0 || ^7.0.0",
@@ -110,7 +110,7 @@
     "eslint-plugin-prettier": "^3.0.0",
     "husky": "^6.0.0",
     "is-ci": "^3.0.0",
-    "jest": "^26.0.1",
+    "jest": "^27.0.0",
     "jest-runner-eslint": "^0.10.0",
     "lint-staged": "^10.2.2",
     "pinst": "^2.0.0",

src/processors/__tests__/snapshot-processor.test.ts

@@ -22,11 +22,9 @@ describe('snapshot-processor', () => {
     it('should only return messages about snapshot specific rules', () => {
       const { postprocess } = snapshotProcessor;
       const result = postprocess([
-        [
-          'no-console',
-          'global-require',
-          'jest/no-large-snapshots',
-        ].map(ruleId => ({ ruleId })),
+        ['no-console', 'global-require', 'jest/no-large-snapshots'].map(
+          ruleId => ({ ruleId }),
+        ),
       ]);
 
       expect(result).toEqual([{ ruleId: 'jest/no-large-snapshots' }]);

src/rules/__tests__/no-deprecated-functions.test.ts

@@ -153,34 +153,23 @@ describe('the rule', () => {
   });
 
   describe.each<JestVersion>([
-    14,
-    15,
-    16,
-    17,
-    18,
-    19,
-    20,
-    21,
-    22,
-    23,
-    24,
-    25,
-    26,
-    27,
+    14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27,
   ])('when using jest version %i', jestVersion => {
     beforeEach(async () =>
       process.chdir(await setupFakeProjectDirectory(jestVersion)),
     );
 
     const allowedFunctions: string[] = [];
-    const deprecations = ([
-      [15, 'jest.resetModuleRegistry', 'jest.resetModules'],
-      [17, 'jest.addMatchers', 'expect.extend'],
-      [21, 'require.requireMock', 'jest.requireMock'],
-      [21, 'require.requireActual', 'jest.requireActual'],
-      [22, 'jest.runTimersToTime', 'jest.advanceTimersByTime'],
-      [26, 'jest.genMockFromModule', 'jest.createMockFromModule'],
-    ] as const).filter(deprecation => {
+    const deprecations = (
+      [
+        [15, 'jest.resetModuleRegistry', 'jest.resetModules'],
+        [17, 'jest.addMatchers', 'expect.extend'],
+        [21, 'require.requireMock', 'jest.requireMock'],
+        [21, 'require.requireActual', 'jest.requireActual'],
+        [22, 'jest.runTimersToTime', 'jest.advanceTimersByTime'],
+        [26, 'jest.genMockFromModule', 'jest.createMockFromModule'],
+      ] as const
+    ).filter(deprecation => {
       if (deprecation[0] > jestVersion) {
         allowedFunctions.push(deprecation[1]);
 

src/rules/__tests__/no-export.test.ts

@@ -23,8 +23,7 @@ ruleTester.run('no-export', rule, {
   ],
   invalid: [
     {
-      code:
-        'export const myThing = "invalid"; test("a test", () => { expect(1).toBe(1);});',
+      code: 'export const myThing = "invalid"; test("a test", () => { expect(1).toBe(1);});',
       parserOptions: { sourceType: 'module' },
       errors: [{ endColumn: 34, column: 1, messageId: 'unexpectedExport' }],
     },
@@ -62,24 +61,20 @@ ruleTester.run('no-export', rule, {
       errors: [{ endColumn: 34, column: 1, messageId: 'unexpectedExport' }],
     },
     {
-      code:
-        'export default function() {};  test("a test", () => { expect(1).toBe(1);});',
+      code: 'export default function() {};  test("a test", () => { expect(1).toBe(1);});',
       parserOptions: { sourceType: 'module' },
       errors: [{ endColumn: 29, column: 1, messageId: 'unexpectedExport' }],
     },
     {
-      code:
-        'module.exports["invalid"] = function() {};  test("a test", () => { expect(1).toBe(1);});',
+      code: 'module.exports["invalid"] = function() {};  test("a test", () => { expect(1).toBe(1);});',
       errors: [{ endColumn: 26, column: 1, messageId: 'unexpectedExport' }],
     },
     {
-      code:
-        'module.exports = function() {}; ;  test("a test", () => { expect(1).toBe(1);});',
+      code: 'module.exports = function() {}; ;  test("a test", () => { expect(1).toBe(1);});',
       errors: [{ endColumn: 15, column: 1, messageId: 'unexpectedExport' }],
     },
     {
-      code:
-        'module.export.invalid = function() {}; ;  test("a test", () => { expect(1).toBe(1);});',
+      code: 'module.export.invalid = function() {}; ;  test("a test", () => { expect(1).toBe(1);});',
       errors: [{ endColumn: 22, column: 1, messageId: 'unexpectedExport' }],
     },
   ],