Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support resolving underlying @jest/globals method from import #1106

Closed
G-Rath opened this issue May 13, 2022 · 1 comment · Fixed by #1122
Closed

Support resolving underlying @jest/globals method from import #1106

G-Rath opened this issue May 13, 2022 · 1 comment · Fixed by #1122

Comments

@G-Rath
Copy link
Collaborator

G-Rath commented May 13, 2022

While we now support @jest/globals via #1094, we currently are still doing our checks against the "local name" of whatever is being imported, e.g.

import { xit as it } from '@jest/globals';

it('is skipped', () => {
  //
});

For the above rules see this as importing it rather than xit - we're already resolving this information as part of our reference scope checking, we just need to expose it.

This will make the API a bit more cumbersome, because we have to change from a boolean type guard check to an "extract" based method (similar to parseExpectCall) but I think it's worth it.

This is required for #1101

@github-actions
Copy link

🎉 This issue has been resolved in version 26.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant