fix: use the last reference definition when checking jest fn scope #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 14, 2022
github-actions bot
pushed a commit
that referenced
this pull request
May 14, 2022
## [26.2.2](v26.2.1...v26.2.2) (2022-05-14) ### Bug Fixes * use the last reference definition when checking jest fn scope ([#1109](#1109)) ([1b2b9c1](1b2b9c1))
|
🎉 This PR is included in version 26.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've thought up a few more theoretical ways that you can have multiple definitions but so far none that are actually valid so vanilla ESLint errors on them and while TypeScript parses them they're not valid.
I have changed the code to grab the last definition, because I think that is technically the more correct one (e.g. for function overloads the last definition has to be the implementation, even though there's no way that'll be something we care about here) & it's cheap.
Resolves #1108