Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure jest globals are enabled in styles config #1241

Merged
merged 1 commit into from Sep 9, 2022

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Sep 9, 2022

This lets us avoid having to do ugly things in #1226 when accessing configs[config].rules[rule] (which currently we're @ts-ignore-ing) because it makes all configs of the same type.

I've labeled this as a fix because I think that is technically true given we're being inconsistent vs the other configs; this also could arguably be a breaking change and we have also spoken about removing the globals at some point once we had proper scope resolving.

@SimenB will wait for you to weight in on if you're happy to land this or if you think it should be in a major version (in which case I'll do something different)

@G-Rath G-Rath requested a review from SimenB September 9, 2022 20:14
@github-actions github-actions bot added the bug label Sep 9, 2022
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be considered breaking.

If people do, reverting and relanding as major is a quick thing 🙂

@G-Rath G-Rath merged commit a165e98 into main Sep 9, 2022
@G-Rath G-Rath deleted the enable-globals-in-styles branch September 9, 2022 23:03
github-actions bot pushed a commit that referenced this pull request Sep 9, 2022
## [27.0.3](v27.0.2...v27.0.3) (2022-09-09)

### Bug Fixes

* ensure jest globals are enabled in `styles` config ([#1241](#1241)) ([a165e98](a165e98))
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

🎉 This PR is included in version 27.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

SimenB pushed a commit to bmish/eslint-plugin-jest that referenced this pull request Sep 10, 2022
## [27.0.3](jest-community/eslint-plugin-jest@v27.0.2...v27.0.3) (2022-09-09)

### Bug Fixes

* ensure jest globals are enabled in `styles` config ([jest-community#1241](jest-community#1241)) ([a165e98](jest-community@a165e98))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants