feat(rules): add prefer-inline-snapshots #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
requested changes
Jul 17, 2018
|
This will probably fail the publish seeing as npm has revoked all tokens and I haven't updated this... Will do later today |
|
Awesome, thank you! |
|
🎉 This PR is included in version 21.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will
Implement the
prefer-inline-snapshotsrule. This rule serves to encourage interspersing snapshots inline in test file code over writing them to a separate_snapshots_/*.snapfile.Why?
The believe is that the snapshot test is easier to comprehend when it can be seen as a whole. This is especially convenient during code-reviews.