fix: no-large-snapshots to allow maxSize of 0 #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
requested changes
Aug 9, 2018
rules/no-large-snapshots.js
Outdated
| (context.options[0] && context.options[0].maxSize) || 50; | ||
| context.options[0] && | ||
| typeof context.options[0].maxSize === 'number' && | ||
| isFinite(context.options[0].maxSize) |
There was a problem hiding this comment.
Could we do Number.isFinite? Then you can drop the typeof check 🙂
| @@ -22,7 +26,9 @@ module.exports = { | |||
| if (lineCount > lineLimit) { | |||
| context.report({ | |||
| message: | |||
| 'Expected Jest snapshot to be smaller than {{ lineLimit }} lines but was {{ lineCount }} lines long', | |||
| lineLimit === 0 | |||
| ? 'Expected to not encounter a Jest snapshot but was found with {{ lineCount }} lines long' | |||
Signed-off-by: Paul Armstrong <parmstrong@twitter.com>
paularmstrong
force-pushed
the
parmstrong/allow-zero-for-snapshot-maxsize
branch
from
ef10b64
to
7e5e4e3
Compare
|
🎉 This PR is included in version 21.20.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thanks @SimenB ! |
This was referenced Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Configuring the rule
jest/no-large-snapshotswith[{ maxSize: 0 }]sets the line limit to50instead of0.Solution: Treat
0as a requirement for no snapshot.