feat(rules): add no-test-return-statement
#136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about |
|
If that should be allowed, let's call it |
|
Yeah that should be allowed, I'll update the name :) |
mattphillips
force-pushed
the
no-test-return
branch
2 times, most recently
from
cd99d8e
to
1a53389
Compare
SimenB
reviewed
Aug 9, 2018
README.md
Outdated
| @@ -90,6 +90,7 @@ for more information about extending configuration files. | |||
| | [no-jest-import][] | Disallow importing `jest` | ![recommended][] | | | |||
| | [no-large-snapshots][] | Disallow large snapshots | | | | |||
| | [no-test-prefixes][] | Disallow using `f` & `x` prefixes to define focused/skipped tests | | ![fixable-green][] | | |||
| | [no-test-return-statement][] | Disallow returning from tests | | | | |||
There was a problem hiding this comment.
"Disallow explicitly returning from tests"?
SimenB
reviewed
Aug 9, 2018
| @@ -0,0 +1,47 @@ | |||
| # Disallow returning from tests (no-test-return-statement) | |||
|
|
|||
| Tests in Jest are void and cannot return values. | |||
There was a problem hiding this comment.
"should be"? Seeing as you can return a promise, and that's unlikely to change (I don't think it's possible to differentiate between an async function and a promise-returning one (at least not if it's transpiled))
mattphillips
force-pushed
the
no-test-return
branch
from
1a53389
to
dc90b5f
Compare
SimenB
approved these changes
Aug 9, 2018
|
/cc @aaronabramov FYI |
SimenB
changed the title
no-test-returnno-test-return-statement
mattphillips
force-pushed
the
no-test-return
branch
from
dc90b5f
to
42409b6
Compare
|
🎉 This PR is included in version 21.20.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a rule for not returning inside of a test. Related issue in Jest: jestjs/jest#6516