feat(rule): add allow option to expect-expect rule #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
requested changes
Aug 24, 2018
There was a problem hiding this comment.
Thanks for the PR!
Could you add some tests using the new option?
Also, please update the schema for the rule: https://eslint.org/docs/developer-guide/working-with-rules#options-schemas
docs/rules/expect-expect.md
Outdated
| } | ||
| ``` | ||
|
|
||
| ### `allow` |
There was a problem hiding this comment.
could we call it assertNames or assertFunctions or something like that instead?
hulkish
force-pushed
the
expect-expect-options
branch
3 times, most recently
from
f79f11a
to
bdb6ec0
Compare
|
@SimenB ok, all set |
hulkish
force-pushed
the
expect-expect-options
branch
from
bdb6ec0
to
8fcae0b
Compare
hulkish
force-pushed
the
expect-expect-options
branch
from
8fcae0b
to
9ec1759
Compare
|
Thank you! |
|
🎉 This PR is included in version 21.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Aug 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
assertFunctionNames: ['expect']option toexpect-expectrule.Note: current valid/invalid tests are left untouched & passing.