Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure toThrow always has a message #154

Closed
garyking opened this issue Sep 21, 2018 · 3 comments · Fixed by #160 or severest/retrobot#238
Closed

Ensure toThrow always has a message #154

garyking opened this issue Sep 21, 2018 · 3 comments · Fixed by #160 or severest/retrobot#238
Labels
good first issue help wanted new rule

Comments

@garyking
Copy link
Contributor

Consider adding a new rule, which checks that toThrow always has one argument, to match the error's message.

This would have helped me a few times, when I used toThrow without any arguments, and it caught a general TypeError, etc. when instead I wanted it to catch a specific custom error.
@SimenB
Copy link
Member

SimenB commented Sep 21, 2018

Yeah, that makes sense! PR welcome 🙂

@macklinu
Copy link
Collaborator

As per the docs, would also want to check that the toThrowError() alias is checked as part of this rule too.

@garyking garyking mentioned this issue Sep 29, 2018
Merged
SimenB pushed a commit that referenced this issue Sep 29, 2018
@garyking @SimenB
feat(rules): require-tothrow-message (#160)
7515458 
This rule checks if `toThrow` or `toThrowError` has a message.

Fixes #154.
@SimenB
Copy link
Member

SimenB commented Sep 29, 2018

🎉 This issue has been resolved in version 21.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dependencies dependencies bot mentioned this issue Oct 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted new rule
Projects
None yet
Milestone
No milestone
3 participants
@garyking @SimenB @macklinu