Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no-jasmine-globals] Verify Jasmine pending() global usage #156

Closed
macklinu opened this issue Sep 21, 2018 · 3 comments
Closed

[no-jasmine-globals] Verify Jasmine pending() global usage #156

macklinu opened this issue Sep 21, 2018 · 3 comments
Labels
good first issue help wanted released

Comments

@macklinu
Copy link
Collaborator

Originally posted by @SimenB in #155 (comment)

@macklinu I wonder if https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-jasmine-globals.md might need the same treatment that pending got in this PR.

This issue is a follow-up to check that the no-jasmine-globals rule doesn't have the same issues reported in #149.
@jdelStrother
Copy link
Contributor

I think I'm running into basically this problem. With a parameter named fail:

function foo(success, fail) {
  fail();
}

I get "Illegal usage of fail, prefer throwing an error, or the done.fail callback`"

@SimenB
Copy link
Member

SimenB commented Nov 17, 2018

Yeah, definitely! Wanna send a PR? You can see #155 for how to implement it 🙂

jdelStrother added a commit to jdelStrother/eslint-plugin-jest that referenced this issue Nov 17, 2018
@jdelStrother
fix(no-jasmine-globals): Fix false positives for pending/fail/spyOn
a3dd6c2 
Prior to this, similarly named local variables & parameters would trigger the
no-jasmine-globals warning

Fixes jest-community#156
@jdelStrother jdelStrother mentioned this issue Nov 17, 2018
Merged
jdelStrother added a commit to jdelStrother/eslint-plugin-jest that referenced this issue Nov 18, 2018
@jdelStrother
fix(no-jasmine-globals): fix false positives for pending/fail/spyOn
7f7b5ed 
Prior to this, similarly named local variables & parameters would trigger the
no-jasmine-globals warning

Fixes jest-community#156
@SimenB SimenB closed this as completed in edbd1a2 Nov 25, 2018
@SimenB
Copy link
Member

SimenB commented Nov 25, 2018

🎉 This issue has been resolved in version 22.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdelStrother @SimenB @macklinu