Some fixes for require-tothrow-message
#161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That doesn't make any sense. Would it be enough to bump
What I usually do is just do |
SimenB
reviewed
Sep 30, 2018
| // code: | ||
| // "const a = 'a'; expect(() => { throw new Error('a'); })" + | ||
| // '.toThrow(`${a}`);', | ||
| // parser: 'babel-eslint', |
There was a problem hiding this comment.
I think it should work if you set ecmaVersion: https://eslint.org/docs/user-guide/configuring#specifying-parser-options
SimenB
requested changes
Sep 30, 2018
|
@SimenB Okay changes have been made. |
SimenB
approved these changes
Sep 30, 2018
|
🎉 This PR is included in version 21.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I allow for any argument type, which would include
TemplateLiteral,CallExpression, etc.I adjusted the tests by throwing actual errors, adding comments, adding more tests.
I couldn't add a test for
TemplateLiteralsince it requiresbabel-eslint.I couldn't break up the commit into multiple commits because one of the precommit hooks staged and commited the entire file, even when I staged only a few lines at a time.