Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefer-strict-equal: Only run if expect is used #163

Merged
merged 2 commits into from Sep 30, 2018
Merged

prefer-strict-equal: Only run if expect is used #163

merged 2 commits into from Sep 30, 2018

Conversation

garyking
Copy link
Contributor

Only run the rule prefer-strict-equal on CallExpressions where expect is used.

SimenB
SimenB requested changes Sep 30, 2018
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case to valid which failed without these changes?

@garyking
test: add a test case where this rule should not apply at all
3212910 
Since it isn't using proper Jest `expect` syntax.
@garyking
Copy link
Contributor Author

@SimenB Okay done, please check it.

@SimenB SimenB merged commit ee2647e into jest-community:master Sep 30, 2018
@SimenB
Copy link
Member

SimenB commented Sep 30, 2018

🎉 This PR is included in version 21.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dependencies dependencies bot mentioned this pull request Oct 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@garyking @SimenB