Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New rule: no-alias-methods #164

Merged
merged 5 commits into from Sep 30, 2018
Merged

New rule: no-alias-methods #164

merged 5 commits into from Sep 30, 2018

Conversation

garyking
Copy link
Contributor

This rule ensures that only the canonical method name from the Jest docs are used for methods, rather than their alias forms. This ensures consistency in codebases, and makes it easier to search for all occurrences of a method.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, thanks!

Thoughts on allowing people to whitelist matchers they do want to keep?

@SimenB
Copy link
Member

SimenB commented Sep 30, 2018

We can follow up with that later if people want it

@SimenB SimenB merged commit 2894eaa into jest-community:master Sep 30, 2018
@SimenB
Copy link
Member

SimenB commented Sep 30, 2018

🎉 This PR is included in version 21.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants