fix(expect-expect): support MemberExpressions in assertFunctionNames #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macklinu
commented
Oct 13, 2018
| @@ -1,23 +1,7 @@ | |||
| 'use strict'; | |||
|
|
|||
| const getDocsUrl = require('./util').getDocsUrl; | |||
|
|
|||
| function getName(node) { | |||
There was a problem hiding this comment.
I replaced the implementation of util/getNodeName with this implementation, which I think handles member expressions a little bit better than the expect-expect implementation.
All tests continue to pass with the refactor too. 👍
| if (index !== -1) { | ||
| unchecked.splice(index, 1); | ||
| break; | ||
| CallExpression(node) { |
There was a problem hiding this comment.
Using the selector query syntax became a little confusing now having to support MemberExpressions, so all CallExpression logic lives in this visitor function now. 😃
macklinu
force-pushed
the
fix/expect-expect-call-expression
branch
from
766272d
to
2bb78f1
Compare
SimenB
approved these changes
Oct 14, 2018
|
🎉 This PR is included in version 21.24.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #175