Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rules): add prefer-todo rule #218

Merged
merged 7 commits into from Jan 29, 2019
Merged

feat(rules): add prefer-todo rule #218

merged 7 commits into from Jan 29, 2019

Conversation

doniyor2109
Copy link
Contributor

Added prefer-todo rule as mentioned #217

@doniyor2109
Copy link
Contributor Author

I came up with prefer-todo name for this rule

@SimenB
Copy link
Member

SimenB commented Jan 27, 2019

Thanks! Can you add code for test.skip as well?

@SimenB
Copy link
Member

SimenB commented Jan 28, 2019 •
edited

I've pushed 2 failing test cases from Jest's code base. The first crashes and the second is a false positive

SimenB
SimenB reviewed Jan 28, 2019
View reviewed changes
rules/prefer-todo.js Outdated Show resolved Hide resolved
macklinu
macklinu reviewed Jan 29, 2019
View reviewed changes
Copy link
Collaborator

@macklinu macklinu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial thoughts. Thanks so much for opening this PR, @doniyor2109! 😄

docs/rules/prefer-todo.md Outdated Show resolved Hide resolved
rules/prefer-todo.js Outdated Show resolved Hide resolved
rules/prefer-todo.js Show resolved Hide resolved
rules/util.js Outdated Show resolved Hide resolved
@SimenB SimenB merged commit 0933d82 into jest-community:master Jan 29, 2019
@SimenB
Copy link
Member

SimenB commented Jan 29, 2019

Thank you!

SimenB pushed a commit that referenced this pull request Jan 29, 2019
@semantic-release-bot
chore(release): 22.2.0 [skip ci]
13b7c98 
# [22.2.0](v22.1.3...v22.2.0) (2019-01-29)

### Features

* **rules:** add prefer-todo rule ([#218](#218)) ([0933d82](0933d82)), closes [#217](#217)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macklinu macklinu macklinu left review comments

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doniyor2109 @SimenB @macklinu