Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rule request: no-empty-title #226

Closed
dashmug opened this issue Feb 18, 2019 · 4 comments · Fixed by #238
Closed

New rule request: no-empty-title #226

dashmug opened this issue Feb 18, 2019 · 4 comments · Fixed by #238
Labels
good first issue help wanted new rule released

Comments

@dashmug
Copy link

dashmug commented Feb 18, 2019

Having an empty string as title is useless. Can we have a rule that prevents this?
@SimenB
Copy link
Member

SimenB commented Feb 18, 2019

Yeah, for sure! Should be pretty straight forward. Wanna send a PR?

@dashmug
Copy link
Author

dashmug commented Feb 18, 2019

Thanks for confirming that the rule doesn't exist yet.

I'm very busy at the moment but I'll see if I can do this during the weekend.

@dashmug
Copy link
Author

dashmug commented Mar 5, 2019

To anyone who's interested, feel free to make a PR. I'll try doing it myself but currently not finding the time to do so (I have not written an eslint rule before).

@himynameisdave himynameisdave mentioned this issue Mar 10, 2019
Merged
SimenB pushed a commit that referenced this issue Mar 15, 2019
@himynameisdave @SimenB
feat(rules): Add no-empty-title rule (#238)
c793b7a 
Fixes #226
@SimenB
Copy link
Member

SimenB commented Mar 15, 2019

🎉 This issue has been resolved in version 22.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted new rule released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(rules): Add no-empty-title rule
2 participants
@SimenB @dashmug