Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rule: no duplicated hooks #231

Closed
eranshabi opened this issue Mar 3, 2019 · 4 comments · Fixed by #298
Closed

New rule: no duplicated hooks #231

eranshabi opened this issue Mar 3, 2019 · 4 comments · Fixed by #298
Labels
help wanted new rule released

Comments

@eranshabi
Copy link
Contributor

A rule that disallows duplicated hooks in the same describe.
For example this code will fail, because you should combine the two beforeEachs into one:

describe('my describe', () => {
    beforeEach(() => {...});
    beforeEach(() => {...});

    it('my it', () => {...})
});
@SimenB
Copy link
Member

SimenB commented Mar 4, 2019

I like it! Wanna send a PR?

@Mark1626
Copy link
Contributor

I'll raise a PR for this

Mark1626 added a commit to m4rkforks/eslint-plugin-jest that referenced this issue Jul 11, 2019
@Mark1626
feat: add rule no-duplicate-hook jest-community#231
a6470a6
Mark1626 added a commit to m4rkforks/eslint-plugin-jest that referenced this issue Jul 11, 2019
@Mark1626
feat: add rule no-duplicate-hook jest-community#231
cdb17a7
@Mark1626 Mark1626 mentioned this issue Jul 11, 2019
Merged
@Mark1626
Copy link
Contributor

@SimenB raised a PR for this

SimenB pushed a commit that referenced this issue Jul 15, 2019
@Mark1626 @SimenB
New Rule - no-duplicate-hooks (#298)
3587240 
Fixes #231
SimenB pushed a commit that referenced this issue Jul 15, 2019
@Mark1626 @SimenB
feat(rules): no-duplicate-hooks (#298)
dd4bbaf 
Fixes #231
@SimenB
Copy link
Member

SimenB commented Jul 15, 2019

🎉 This issue has been resolved in version 22.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted new rule released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New Rule - no-duplicate-hooks m4rkforks/eslint-plugin-jest
3 participants
@SimenB @eranshabi @Mark1626